Skip to content

Conversation

@ChronosSF
Copy link
Member

No description provided.

@ChronosSF ChronosSF requested a review from Copilot October 22, 2025 15:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an IIS deployment issue by making the base URL configurable based on the build mode. The main change ensures that the application uses /react-demos/ as the base path in production while using / for local development.

Key Changes:

  • Made the Vite configuration mode-aware to set different base URLs for production vs. development
  • Updated the router to use the environment-based base URL instead of a hardcoded value
  • Added explicit type definitions for Vite client and Node to TypeScript configuration

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
browser/vite.config.js Updated to accept mode parameter and set base URL conditionally based on environment
browser/src/index.tsx Changed BrowserRouter basename to use environment variable instead of hardcoded path
browser/package.json Modified build script to explicitly specify production mode
browser/tsconfig.json Added Vite client and Node type definitions
browser/src/navigation/SamplesBrowser.json Auto-generated timestamp update
browser/public/meta.json Auto-generated timestamp update

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ChronosSF ChronosSF merged commit 72055b4 into vnext Oct 23, 2025
5 checks passed
@ChronosSF ChronosSF deleted the sstoychev/updating-vite-config-for-iis branch October 23, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants