fix(mask): Correct auto-fill handling with literals #2006
Merged
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the browser auto-fills a masked input field, it may include literal characters as part of the filled value. The previous implementation did not correctly handle such cases, leading to incorrect parsing and display of the input value.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect handling of browser auto-filled values in masked input fields when the mask contains literal characters. The fix ensures that auto-filled values are properly parsed to extract only the input characters, excluding mask literals.
- Added parsing of auto-filled values to strip literal characters before updating the input
- Extended auto-fill case handling to include empty string input types
- Added test coverage for auto-fill behavior with literal-containing masks
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/mask-input/mask-input-base.ts | Added parser.parse() call to strip literals from auto-filled values and included empty string in auto-fill case |
| src/components/mask-input/mask-input.spec.ts | Added test case verifying correct handling of auto-filled values containing mask literals |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the browser auto-fills a masked input field, it may include literal characters as part of the filled value. The previous implementation did not correctly handle such cases, leading to incorrect parsing and display of the input value.