Skip to content

refactor(stepper): Stepper and step refactor#2136

Merged
rkaraivanov merged 3 commits intomasterfrom
rkaraivanov/stepper-refactor
Mar 16, 2026
Merged

refactor(stepper): Stepper and step refactor#2136
rkaraivanov merged 3 commits intomasterfrom
rkaraivanov/stepper-refactor

Conversation

@rkaraivanov
Copy link
Member

Description

  • Sync stepper and steps through Lit context
  • Abstracted state logic to a separate file
  • Moved common types and animations to a common folder
  • Updated tests and stories to reflect the changes

Type of Change

  • Refactoring (code improvements without functional changes)

Testing

The test suite is rewritten to accommodate for the removed "public private" properties maintaining
the scenario and expected behavior of each unit test as close as possible.

Accessibility has been tested with the latest version on NVDA (2025.3.3) in Chrome and Firefox and
it is correctly announcing state and intention.

Checklist

  • My code follows the project's coding standards
  • I have tested my changes locally
  • I have updated documentation if needed

- Sync stepper and steps through Lit context
- Absracted state logic to a separate file
- Moved common types and animations to a common folder
- Updated tests and stories to reflect the changes
@RivaIvanova
Copy link
Member

Keyboard navigation with ArrowLeft and ArrowRight is working strangely when the stepper is vertical. It is not clear from the spec what the expected behavior exactly is, but pressing ArrowLeft always navigates to the next step and ArrowRight to the previous step. Even though the direction is LTR, it behaves as if the direction is RTL.

@rkaraivanov
Copy link
Member Author

@RivaIvanova
Nice catch, I've restored the old behavior and will revise the specification.

@rkaraivanov rkaraivanov merged commit 9bceaef into master Mar 16, 2026
7 checks passed
@rkaraivanov rkaraivanov deleted the rkaraivanov/stepper-refactor branch March 16, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants