Skip to content

Conversation

@rstratkovinfrag
Copy link
Contributor

Introduce azure pipeline to build artifacts for grid demos react.

@dkamburov dkamburov merged commit c2e2a54 into vnext Apr 24, 2025
1 check passed
@dkamburov dkamburov deleted the rstratkov/grid-demos-react-new-azure-pipeline branch April 24, 2025 10:43
type: boolean
default: false
- name: shouldCleanPostExecution
displayName: 'Clean all pipeline dirs after the pipeline finishes?'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using Azure-procurred agents, we don't need optional post-execution cleanup. Please remove this variable.

customCommand: 'install --legacy-peer-deps'
customEndpoint: 'public proget'

# - task: Npm@1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rstratkovinfrag , please add a TODO comment as to why this commented-out code is important to be left here and what remains to be done so that we can uncomment it.
This is crucial to the not-yet-complete implementation of the pipeline.

artifact: 'dist.grid-demos-react'
publishLocation: 'pipeline'

- ${{ if eq(parameters.shouldCleanPostExecution, true) }}:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using Azure-procurred agents, we don't need optional post-execution cleanup. Please remove this step.

@rstratkovinfrag
Copy link
Contributor Author

@turbobobbytraykov Here is PR with comments taken care of: #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants