Skip to content

feat: add search bar to filter notes#3

Merged
IgnorancePulls merged 2 commits into
mainfrom
feat/search-notes
Mar 24, 2026
Merged

feat: add search bar to filter notes#3
IgnorancePulls merged 2 commits into
mainfrom
feat/search-notes

Conversation

@IgnorancePulls
Copy link
Copy Markdown
Owner

Summary

  • Adds a search input below the header on the home page
  • Filters notes in real time by title and content
  • Shows empty state with search icon when no notes match

Test plan

  • Type in the search bar — notes filter instantly
  • Search by title and by content both work
  • When nothing matches — "No notes match your search." empty state appears
  • Empty search shows all notes again

🤖 Generated with Claude Code

Adds a search input that filters notes by title and content in real time.
Shows an empty state when no notes match the query.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Mar 24, 2026

DeepSource Code Review

We reviewed changes in ba0186e...34240a7 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Mar 24, 2026 9:29a.m. Review ↗
Secrets Mar 24, 2026 9:29a.m. Review ↗
Test coverage Mar 24, 2026 9:29a.m. Review ↗

Comment thread src/pages/HomePage.tsx
};

const filteredNotes = notes.filter((note) => {
const q = search.toLowerCase();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable name is too small


Short variable names affect code readability and complicate code refactoring, because of the difficulty in searching and replacing such short characters.

DeepSource cannot process coverage artifacts reported from merge commits.
Using github.event.pull_request.head.sha ensures the real PR commit is used.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@IgnorancePulls IgnorancePulls merged commit 34240a7 into main Mar 24, 2026
2 of 5 checks passed
Comment thread src/pages/HomePage.tsx
};

const filteredNotes = notes.filter((note) => {
const q = search.toLowerCase();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable name is too small


Short variable names affect code readability and complicate code refactoring, because of the difficulty in searching and replacing such short characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant