Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a GitHub Actions workflow to automate deployment to WordPress.org's plugin repository and create GitHub release assets when a new release is published.
Key changes:
- Adds automated deployment workflow triggered on release publication
- Configures WordPress.org SVN deployment with dry-run mode enabled
- Includes automatic ZIP file generation and attachment to GitHub releases
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # # Optional: If your plugin is using composer dependencies, we want to include them | ||
| # # WITHOUT the dev dependencies. | ||
| # - name: Build | ||
| # run: | | ||
| # npm install | ||
| # npm run build |
There was a problem hiding this comment.
The comment is misleading. The commented build step runs npm commands, not composer. The project does have composer dev dependencies (phpstan) that should be excluded from production builds. Consider either removing this comment or updating it to accurately reflect that it's for npm/build assets, and add a separate step for composer production dependencies if needed using composer install --no-dev.
| # # Optional: If your plugin is using composer dependencies, we want to include them | |
| # # WITHOUT the dev dependencies. | |
| # - name: Build | |
| # run: | | |
| # npm install | |
| # npm run build | |
| # # Optional: If your plugin is using npm (Node.js) build assets, run the build here. | |
| # - name: Build assets | |
| # run: | | |
| # npm install | |
| # npm run build | |
| # | |
| # # Optional: If your plugin is using composer dependencies, install them WITHOUT the dev dependencies. | |
| # - name: Install Composer production dependencies | |
| # run: composer install --no-dev --optimize-autoloader |
| uses: 10up/action-wordpress-plugin-deploy@stable | ||
| with: | ||
| generate-zip: true | ||
| dry-run: true |
There was a problem hiding this comment.
The dry-run: true flag means this workflow will not actually deploy to WordPress.org. For a production release workflow, this should be set to false. If this is intentional for testing purposes, consider adding a comment explaining why dry-run is enabled.
| dry-run: true | |
| dry-run: false |
No description provided.