Skip to content

#80 Improve boundary layer models with compressible DeChant skin friction/Van Driest heat flux.#85

Merged
TimothyEDawson merged 9 commits intodevelopfrom
80-skin-friction-model-replacement
Mar 27, 2026
Merged

#80 Improve boundary layer models with compressible DeChant skin friction/Van Driest heat flux.#85
TimothyEDawson merged 9 commits intodevelopfrom
80-skin-friction-model-replacement

Conversation

@nlaing613
Copy link
Copy Markdown
Contributor

This pull request introduces compressible closed-form models for skin friction and wall heat flux and modularizes these models and their inputs.

The main changes are located in:

  • models/wall_models.py
    Contains separate heat flux and skin friction classes and wall-state (key parameters used by models).
  • models/boundary_layer.py
    Simplified calculation by offloading to wall_models.py.

Included changes

  • Explicit wall-model selection via: wall_models=(SkinFriction, HeatFlux)
  • Refactored the boundary-layer implementation to use a WallState abstraction (get_wall_state), decoupling wall-model evaluations from the core solver and enabling modular skin-friction and heat-flux models
  • Allowed wall temperature specification without requiring a heat-flux model for Cf calculation.
  • Made boundary-layer instantiation depend on the selected skin-friction model rather than the previous boolean flag
  • Added Van Driest recovery-temperature model for compressible heat-flux calculations
  • Retain low-Re analytical solutions incompressible skin friction and heat flux.
  • Updated the constant-area duct validation case naming/context

@nlaing613 nlaing613 linked an issue Mar 19, 2026 that may be closed by this pull request
@TimothyEDawson
Copy link
Copy Markdown
Collaborator

@nlaing613 I think this is good to go! All of the tests and example cases look good to me. The results from optimization.py seem to be a little bit different, might be worth digging into that a bit more later.

Copy link
Copy Markdown
Collaborator

@TimothyEDawson TimothyEDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already added my requested changes directly to the branch, so it should be good to go!

@TimothyEDawson TimothyEDawson merged commit 5d96b0a into develop Mar 27, 2026
9 checks passed
@TimothyEDawson TimothyEDawson deleted the 80-skin-friction-model-replacement branch March 27, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skin friction model replacement

2 participants