Incorrect character icon in fish 4.3.1

[shahms]

Describe the bug

After upgrading to fish 4.3.1, the wrong icon is chosen for the character item with the default keybindings.

Steps to reproduce

1. Update to fish 4.3.1
2. Use the default key bindings and default character icon
3. See that the prompt character is the vi mode default icon

Screenshots

❮ fish --version
fish, version 4.3.1
❮ echo "$fish_bind_mode"
default
❮ echo "$fish_key_bindings"
fish_default_key_bindings
❮ echo $tide_character_icon
❯
❮ echo $tide_character_vi_icon_default
❮

Environment

Output of tide bug-report:

fish version: 4.3.1
tide version: 6.2.0
term: tmux-256color
os: MacOS Tahoe 26.1
terminal emulator: iTerm2
fish startup: 26.82 millis
fisher plugins: ilancosman/tide@v6 jorgebucaran/fisher

Additional context

It appears as though $fish_key_bindings is unset while executing _tide_item_character for some reason. It is set in an otherwise empty fish_prompt function.

[shahms]

It appears as though this is related to the way tide uses subshells and the change to making fish_key_bindings a global variable rather than a universal one. Changing fish_prompt to:

diff --git a/.config/fish/functions/fish_prompt.fish b/.config/fish/functions/fish_prompt.fish
index dda6f17edbb36190a9992ed9730ed8a5acd21719..994513d32aec9ee9681019c972996fdd2c361a72 100644
--- a/.config/fish/functions/fish_prompt.fish
+++ b/.config/fish/functions/fish_prompt.fish
@@ -41,7 +41,7 @@     _tide_status=\$status _tide_pipestatus=\$pipestatus if not set -e _tide_repaint
         jobs -q && jobs -p | count | read -lx _tide_jobs
         $fish_path -c \"set _tide_pipestatus \$_tide_pipestatus
 set _tide_parent_dirs \$_tide_parent_dirs
-PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_bind_mode=\$fish_bind_mode set $prompt_var (_tide_2_line_prompt)\" &
+PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_bind_mode=\$fish_bind_mode fish_key_bindings=\$fish_key_bindings set $prompt_var (_tide_2_line_prompt)\" &
         builtin disown

         command kill \$_tide_last_pid 2>/dev/null
@@ -69,7 +69,7 @@     _tide_status=\$status _tide_pipestatus=\$pipestatus if not set -e _tide_repaint
         jobs -q && jobs -p | count | read -lx _tide_jobs
         $fish_path -c \"set _tide_pipestatus \$_tide_pipestatus
 set _tide_parent_dirs \$_tide_parent_dirs
-PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_bind_mode=\$fish_bind_mode set $prompt_var (_tide_2_line_prompt)\" &
+PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_bind_mode=\$fish_bind_mode fish_key_bindings=\$fish_key_bindings set $prompt_var (_tide_2_line_prompt)\" &
         builtin disown

         command kill \$_tide_last_pid 2>/dev/null

seems to fix the issue for me.

[yonatan-sevenai]

On top of @shahms's answer you should change lines 104 and 131 to support the change with the 1 line prompt to
PATH=\$(string escape \"\$PATH\") CMD_DURATION=\$CMD_DURATION fish_bind_mode=\$fish_bind_mode fish_key_bindings=\$fish_key_bindings set $prompt_var (_tide_1_line_prompt)\" &