Skip to content

Conversation

@ivanimanishi
Copy link
Member

USD 20 is still used at IE for cortex 10.3, so we need to make sure the code still builds for it.

This was done following @johnhaddon's suggestions.

IsContainer() was added by usd 21, but we still need to support usd 20
at ImageEngine
@ivanimanishi
Copy link
Member Author

Note that we are only adding this to the 10.3 maintenance branch because 10.4 should be using a more modern USD at IE as well.

@ivanimanishi ivanimanishi merged commit 210c457 into ImageEngine:RB-10.3 Mar 30, 2022
@ivanimanishi ivanimanishi deleted the usd20Support branch March 30, 2022 22:05
@johnhaddon
Copy link
Member

Note that we are only adding this to the 10.3 maintenance branch because 10.4 should be using a more modern USD at IE as well.

It'll end up on main as well when we do our usual merge forwards. I don't think that should be a problem though?

@ivanimanishi
Copy link
Member Author

Note that we are only adding this to the 10.3 maintenance branch because 10.4 should be using a more modern USD at IE as well.

It'll end up on main as well when we do our usual merge forwards. I don't think that should be a problem though?

I thought that might end up being the case. There is not problem, of course. It's just unnecessary. But if it's easier to keep the change, it's fine.

@johnhaddon
Copy link
Member

But if it's easier to keep the change, it's fine.

I can remove it once we've done the merge - it'd be nice to rip out all code for USD versions now the minimum version has moved up for Cortex 10.4. Remind me though, what is the minimum we need to support now? You mentioned that IE is using 22.03 with Cortex 10.4 standalone, but #1226 maintains compatibility with 20.08 for use in Houdini 18.5 at IE. Have you upgraded to Houdini 19 at the same time as Cortex 10.4, in which case the new minimum would be 21.08 (what Houdini 19 uses)?

@johnhaddon
Copy link
Member

In #1256 I've played it safe and removed support for everything below 20.08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants