IECoreUSD : Fix builds using USD 20.08 #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version is required by Houdini 18.5 and does not have GetAsString
andrewkaufman
added
bug
Contributor
|
I don't really recall whether I thought through the performance consequences of this. GetString is labelled as a potential memory hazard, because it results in potentially long strings being permanently held by the SdfPath. But I guess it will be faster if we reuse this path, which is probably happening. And neither the performance or memory consequences are probably significant to us ... this is probably fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version is required by Houdini 18.5 and does not have
SdfPath::GetAsString