Merge branch 'RB-10.3' into 'RB-10.4' #1312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed huge FPS drops in scenes with a huge amount of `SceneShapes`. Profiling showed that a lot of time is spend by `SubSceneOverride` requesting draw updates from the shapes in the scene. This also happens for shapes that are set as hidden, what we consider a bug/flaw in Maya's VP2 drawing API. To alleviate this issue, we derive the proxy from `SceneShape` and inherit all of it's behaviour with the exception, that we don't register it as drawable. This allows us to replace `SceneShape`s with its proxy implementation, where only the data reading capabilities are needed, e.g. layouts or rigs.
SConstruct : Fix slash error on Windows
Changing all `staticmethod`s to `classmethod`s and replacing all method calls from within the class to use either `self` or `cls` instead of the class name. This allows for easier inheritance and less code duplication in subclasses
With overriding the `__new__` method of the `FnSceneShape` class we change the object type during construction and before initialization. This gives us the ability to use `FnSceneShape` regardless if it's dealing with a `SceneShape` or it's proxy version.
We add the `shapeType` argument to the methods that can create a `SceneShape` node to specify if we want to create an `ieSceneShape` or its proxy version. If we don't pass in the argument `FnSceneShape` will create shapes of the type it was initially created with.
Moving the node creation in the `setUp` method, which is called before every test method, gives subclasses the ability to run the same test cases with a different node. This is e.g. useful for `ieSceneShapeProxy` as we need to make sure that it behaves the same way as it's non proxy version
…ath::Box3d and Imath::M44d to DD::Image::Matrix4.
We want to maintain the world space matrix instead of transforming the points so we can more easily round trip scene cache in/out of nuke. This allows to write the bounds as the SceneInterface expects ( local space ). Due to some kind of reset happening in the SourceGeo source code, we need to store the matrix in create_geometry and apply in the geometry_engine. I think this should work fine considering that Op are instantiate per output context ( frame ) so we shouldn't have a clash in the map data structure.
Allow to query the Nuke's scene representation through the SceneInterface API.
…round trip hierarchy.
…e as a cortex SceneInterface
Nuke live scene
SceneShapeProxy
Member
Author
|
Seems like this approach requires merging a commit to 10.3 directly if I resolve the conflicts via the web interface, so I'll likely close this PR and do the merge between 10.3 and 10.4 via the command line once I've setup git with internet access tomorrow... |
Member
Author
|
Ok. I think I got it by using a temporary branch. But I'll only merge it tomorrow, after reviewing it one more time. |
lucienfostier
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.