Merge 10.3.8.1 onto RB-10.4 #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In df78cb8 changes were made to the `LiveScene` implementation so that we take into account visibility overrides higher up the hierarchy. This makes the changes introduced in 07b40ee obsolete. In fact a `scene:visibility` value stored in the cache stomps over the visibility determination done by `LiveScene`.
In case we have a root location i.e. we set a shape node to `objectOnly` and we also set "draw root bounds", the visibility of the current instance was never taken into accout and we draw the bounds regardless. We address this and skip adding a render item for every instance that is set to invisible.
Visibility override fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.