GL primitives : Add utilities to query OpenGL draw mode #1347
Conversation
These are needed by Gaffer, to allow selection wireframes to be drawn successfully without z-fighting with the underlying geometry. See GafferHQ/gaffer#5220.
danieldresser-ie
left a comment
danieldresser-ie
left a comment
There was a problem hiding this comment.
I don't see anything here to prevent merging at the moment, though I did make one comment.
| return true; | ||
| } | ||
| } | ||
| return glslVersion() < 150; |
There was a problem hiding this comment.
This all looks like it will work fine, but it does feel a little weird that it is so close to renderMode. Why not just call renderMode and check the "linear" return ... I guess it could be perf critical so you want to skip the basis compare? Why this check if state->get<UseGLLines>() is valid before dereferencing it, but renderMode doesn't?
There was a problem hiding this comment.
I guess it could be perf critical so you want to skip the basis compare?
Yep, that.
Why this check if state->get() is valid before dereferencing it, but renderMode doesn't?
The docs for Primitive::render() say that state must be complete, so that the get() will never return null. In practice in Gaffer the state will also be complete here, but since I didn't document that as a requirement I threw in the check.
2 participants
These are needed by Gaffer, to allow selection wireframes to be drawn successfully without z-fighting with the underlying geometry. See GafferHQ/gaffer#5220.