New Imath fixes #1350
Merged
New Imath fixes #1350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to link to Imath when it is built as a shared library, as we do in the dependencies.
johnhaddon
reviewed
Apr 11, 2023
.github/workflows/main/options.posix
Outdated
| BOOST_LIB_SUFFIX = "" | ||
|
|
||
| OPENEXR_INCLUDE_PATH = includes | ||
| ILMBASE_INCLUDE_PATH = includes + "\\imath" |
Member
There was a problem hiding this comment.
Why are we using a Windows style path in the Posix config?
Collaborator
Author
There was a problem hiding this comment.
The CopyPaste giveth, and the CopyPaste taketh away.
Fixed and squashed into ffe6f9e
Member
There was a problem hiding this comment.
On Linux the directory is Imath (initial capital I). But now I think about it, it might be better to do this once in the SConstruct rather than in all the build configs - this is where we deal with the identical thing for OpenEXR : https://github.com/ImageEngine/cortex/blob/main/SConstruct#L1056-L1058.
Collaborator
Author
There was a problem hiding this comment.
Good idea, that is a bit cleaner and clearer. Fixed and squashed into 246961d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the recent dependencies on Windows, I came across a couple small fixes that needed to be made to build for Imath 3.x.
Checklist