SceneShape: Fix reading of time samples for expanded link locations #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading a link at a location the determination if time is added to the `linkAttributeData` was solely based on the connection of the time plug. In case the time plug of the scene shape is not connected to maya's global time output, we assumed a time remapping to happen. This leads to adding the current time to the `linkAttributeData` if the location is an expanded child location, because we connect the out time of a scene shape to it's childs in time on expansion, which breaks this assumption. We address this issue by traversing the time plug's connection chain and check if the plug is connected to any scene shape or maya's global time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading a link at a location the determination if time is added to the
linkAttributeDatawas solely based on the connection of the time plug. In case the time plug of the scene shape is not connected to maya's global time output, we assumed a time remapping to happen.This leads to adding the current time to the
linkAttributeDataif the location is an expanded child location, because we connect the out time of a scene shape to it's childs in time on expansion, which breaks this assumption.We address this issue by traversing the time plug's connection chain and check if the plug is connected to any scene shape or maya's global time
Checklist