USD PrimitiveAlgo : Fix crash loading skinned facevarying normals #1436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add stage timecode range, so we get a playback range in `usdview`. - Rename `Skeleton` prim to "skel", because having it share a name with one of its joints was confusing.
The call to `skinningQuery.GetJointMapper()` can not only reorder transforms but can also omit them. This occurs when SkelBindingAPI uses a `skel:joints` attribute to bind a mesh to a subset of joints, allowing the weights for other joints to be omitted. We were assuming that the mapped transform array had the same length as the input array, and were running off the end of the array.
Contributor
|
LGTM. As mentioned offline, my only nitpick is that the name "orderedXforms" seems rather misleading, now that we know that this is not just a different ordering of the xform list, but that has no impact on correctness, and shouldn't prevent merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
skinningQuery.GetJointMapper()can not only reorder transforms but can also omit them. This occurs when SkelBindingAPI uses askel:jointsattribute to bind a mesh to a subset of joints, allowing the weights for other joints to be omitted. We were assuming that the mapped transform array had the same length as the input array, and were running off the end of the array.