IECoreAlembic : Support velocity on meshes and curves#706
Merged
johnhaddon merged 1 commit intoImageEngine:masterfrom Feb 8, 2018
Merged
IECoreAlembic : Support velocity on meshes and curves#706johnhaddon merged 1 commit intoImageEngine:masterfrom
johnhaddon merged 1 commit intoImageEngine:masterfrom
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already supported this property on points, but neglected to support it on meshes and curves.
This is all pretty straightforward, the only thing that seemed odd to me while implementing it is that PointsReader and CurvesReader pass the sampleSelector once into *Schema.getValue(), but MeshReader uses *Property.get( ..., sampleSelector ). I wasn't sure why this was happening, so I kept the current convention.