-
Notifications
You must be signed in to change notification settings - Fork 0
Pulling git cherry-pick guide from template #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
based on updating Imageomics Guide from Collab template Pull from Collab Guide [PR 35](Imageomics/Collaborative-distributed-science-guide#35) * Add link to cherry-pick guide for instructions on updating personalized sites * Fix typo in acknowledgments * Clarify description and add link to cherry-pick guide for more info * Add some intro to the page * Add a little extra context/clarity Co-authored-by: Matt Thompson <31709066+thompsonmj@users.noreply.github.com> --------- Co-authored-by: Matt Thompson <31709066+thompsonmj@users.noreply.github.com>
hlapp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment about a (minor) potentially confusing statement.
Aside from that, I'm not sure what is being changed in the Acknowledgments text in the README, making me wonder whether this is a bogus change?
Pull from Collab Guide [PR 36](Imageomics/Collaborative-distributed-science-guide#36)
hlapp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
To nitpick, I notice some instructions pertaining strictly to using vi as the commit message editor, which is indeed the default but is also customizable as some other editor such as nano. Perhaps consider adding a note somewhere that those instructions make this assumption of using the default editor.
That said, it's not unreasonable to assume that if someone made the effort to change the default, they'd know what to do.
The purpose of including the |
Add cherry-pick guide for fetching new material from upstream based on updating Imageomics Guide from Collab template