Skip to content

Conversation

@EmersonFras
Copy link
Contributor

Summary

This PR removes the starting_idx parameter (-x) from the command line arguments and internal logic.

Previously, starting_idx was used to manually resume interrupted downloads. With the recent addition of check_existing_images (introduced in PR #43), the tool now automatically detects existing files in the output directory and filters them out of the download queue. Consequently, the manual index parameter is redundant and complicates the validation of expected image counts.

Changes Made

  • Removed Argument: Deleted the -x / --starting-idx argument definition from parse_argsin __main__.py.
  • Updated Main Logic: Removed the starting_idx argument from the check_existing_images function call.
  • Updated Download Calls: Removed the starting_index parameter from both download_images calls (standard and downsampled paths).

Closes #45

Copy link
Member

@egrace479 egrace479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done!

@EmersonFras EmersonFras changed the title feat: Remove starting_idx parameter (closes #45) bug: Remove starting_idx parameter (closes #45) Dec 19, 2025
@EmersonFras EmersonFras merged commit 2b87064 into main Dec 19, 2025
7 checks passed
@EmersonFras EmersonFras changed the title bug: Remove starting_idx parameter (closes #45) feat: Remove starting_idx parameter (closes #45) Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update number of expected images validation check

3 participants