Merged
Conversation
* Update Dockerfile * Update Dockerfile
…files. (OHIF#5494) Added bun audit security check in build process. Removed bun caching.
… viewport after converting Labelmap to Surface (OHIF#5488) * fix: unable to draw segment after 3d layout * comment update ---------
OHIF#5293) * chore: Minor adjustment to generateAcceptHeader function signature to reflect expected return type. Signed-off-by: Luis M. Santos <luis.santos2@nih.gov> * fix: Added switch to skip the Accept header generation when requesting metadata. WADO metadata request is more likely to return JSON and some VNAs do not like the extra options in the Accept header. Also, passing an empty array is not sufficient because somewhere we still include a comma that breaks the Accept header. It's better to omit it for the metadata request only. Signed-off-by: Luis M. Santos <luis.santos2@nih.gov> * chore: Added new HeadersInterface interface type docstrings. Signed-off-by: Luis M. Santos <luis.santos2@nih.gov> * chore: Refactored getAuthorizationHeader() function signature so it is typed checked. Of course, I upgraded the module to a TypeScript module. Moved the request header interfaces into its own TypeScript module (RequestHeaders.ts) in the core types. Signed-off-by: Luis M. Santos <luis.santos2@nih.gov> * chore: Refactored the user logic to include a TypeScript interface. As a result, upgraded the source file to TypeScript. Removed the User interface from RequestHeaders module and moved them to the user module. Signed-off-by: Luis M. Santos <luis.santos2@nih.gov> * chore: Updated function signatures, user import, and confirmed unit tests are passing. Signed-off-by: Luis M. Santos <luis.santos2@nih.gov> * chore: Minor stylistic adjustment to getAuthorizationHeader.test.ts Signed-off-by: Luis M. Santos <luis.santos2@nih.gov> * chore: Added missing comments. Signed-off-by: Luis M. Santos <luis.santos2@nih.gov> * chore adjusted generateWadoHeader parameter's name and added comment about the expected default header. Signed-off-by: Luis M. Santos <luis.santos2@nih.gov> * Just tweaking the interface a bit to be more consistent. * fix authorization header signature change --------- Signed-off-by: Luis M. Santos <luis.santos2@nih.gov> Co-authored-by: Bill Wallace <wayfarer3130@gmail.com> Co-authored-by: Alireza <ar.sedghi@gmail.com>
…ns. OHIF-2416, OHIF-2369 (OHIF#5735) * Updated screenshots for failing tests due to FOV improvements. --------- Co-authored-by: Bill Wallace <wayfarer3130@gmail.com>
* fix: SR validation * Adding links to cs3d * Update to dcmjs 0.48.0 * Update package files to include updated adapter * Update package files --------- Co-authored-by: Bill Wallace <wayfarer3130@gmail.com> Co-authored-by: arul-trenser <arul.mozhi@trenser.com>
* Remove all but one log message for mappings. * fix: NPE when no segmentations list returned.
…er for arrow navigation. (OHIF#5759) * fix(segmentation): Use jumpToSegmentNext instead of jumpToSegmentCenter for arrow navigation. * Fixed unit tests.
…gation. (OHIF#5774) * Update to CS3D 4.15.28.
Will address a few more comments in a separate PR released after this one into 3.13 * fix(HistoryMemo): Segmentation delete wasn't remembered * Temporary add of package.json linking * fix: Use newer dcmjs version and delete segmentation with history cs3d
…use generic jumpToSegmentCenter if a segment center is available. (OHIF#5785)
…:ImagingDataCommons/ViewersV3 into chore/update-to-ohif-3.12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment