fix: Interval calculation for exponential reconnect#33
Merged
Imgkl merged 6 commits intoImgkl:pre-releasefrom Nov 24, 2024
Merged
fix: Interval calculation for exponential reconnect#33Imgkl merged 6 commits intoImgkl:pre-releasefrom
Imgkl merged 6 commits intoImgkl:pre-releasefrom
Conversation
Peetee06
force-pushed
the
fix/exponential-interval-calculations
branch
from
b378e53 to
a401273
Compare
Merged
Imgkl
approved these changes
Nov 24, 2024
Imgkl
pushed a commit
that referenced
this pull request
Dec 11, 2024
* fix: Interval calculation for exponential reconnect * test: Add tests for multipart requests * ref: Remove unnecessary async keyword * test: Add tests for headers * test: Add tests for correctly passing Url * test: Add tests for get and post method
Imgkl
pushed a commit
that referenced
this pull request
Dec 11, 2024
* fix: Interval calculation for exponential reconnect * test: Add tests for multipart requests * ref: Remove unnecessary async keyword * test: Add tests for headers * test: Add tests for correctly passing Url * test: Add tests for get and post method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some initial tests for the client.
During implementation I found a bug in the calculation of the exponential reconnect interval. It didn't start with the initial value but rather the double of that.
This also adds dependencies: