Insert table to ppt by marrip · Pull Request #99 · InPreD/PRONTO

marrip · 2026-01-29T13:40:54Z

I have started on the refactoring. I have introduced pandas and moved the part that checks the column headers and moves the columns around in an extra function. I am keeping additional headers in the table but I place them to the far right so that they will get ignored with the current setup but I think we should discuss if they should be handled differently. I will continue with the refactoring but please feel free to give feedback and suggestions in the meantime.

…nts and clean up

xiaoliz0 · 2026-02-03T12:34:11Z

Hi Martin,
Thanks for the contribution to the new function! I am not very confident to review the details with the codes. I did some testings in our environment with your new codes. There is one issue that one column "AF_tumor_DNA" in the tables in report showing wrong format. It should be float I think. This number should be displayed to three decimal places, but now there are many many numbers.

marrip · 2026-02-03T14:30:16Z

Hi Martin, Thanks for the contribution to the new function! I am not very confident to review the details with the codes. I did some testings in our environment with your new codes. There is one issue that one column "AF_tumor_DNA" in the tables in report showing wrong format. It should be float I think. This number should be displayed to three decimal places, but now there are many many numbers.

Hey Xiaoli, thanks for your feedback! I have added another small function that can basically convert any column into the 2 decimal format that you want. I applied it for AF_tumor_DNA which hopefully fixes the issue you were seeing 🤞

xiaoliz0 · 2026-02-05T12:30:18Z

Hi Martin, Thanks for the contribution to the new function! I am not very confident to review the details with the codes. I did some testings in our environment with your new codes. There is one issue that one column "AF_tumor_DNA" in the tables in report showing wrong format. It should be float I think. This number should be displayed to three decimal places, but now there are many many numbers.

Hey Xiaoli, thanks for your feedback! I have added another small function that can basically convert any column into the 2 decimal format that you want. I applied it for AF_tumor_DNA which hopefully fixes the issue you were seeing 🤞

Hi Martin, I did a quick testing today and there is some errors related.

marrip · 2026-02-05T13:58:18Z

Hi Martin, Thanks for the contribution to the new function! I am not very confident to review the details with the codes. I did some testings in our environment with your new codes. There is one issue that one column "AF_tumor_DNA" in the tables in report showing wrong format. It should be float I think. This number should be displayed to three decimal places, but now there are many many numbers.

Hey Xiaoli, thanks for your feedback! I have added another small function that can basically convert any column into the 2 decimal format that you want. I applied it for AF_tumor_DNA which hopefully fixes the issue you were seeing 🤞

Hi Martin, I did a quick testing today and there is some errors related.

I think I know why this happens. I have introduced a fix. Instead of assuming float it will convert string to float and then do the decimal rounding

…ame to slide

marrip · 2026-02-05T14:06:55Z

I have refactored some more. I am quite happy with the result, we are actually testing smaller parts now and now that they work on their own. Not sure if we should maybe add a test for the whole function insert_table_to_ppt. You could give me your use case and we test that it produces a certain output every time.

xiaoliz0 · 2026-02-12T11:17:12Z

+				cell.text_frame.paragraphs[0].font.size = Pt(font_size)
+
+		# add table title
+		pronto.add_table_title(shapes, table_name, left_h, top_h, width_h, 0.25, 8, print_row_num, slide_idx, total_slides_needed, rows)


Do you want to use pronto.add_table_name here? I cannot find this function in the pronto module.

yes, thanks for pointing that out! I fixed it

xiaoliz0 · 2026-02-12T14:48:07Z

Hi Martin,
Some other errors with further testings in outside.

There are different printing format for this column in the tables in the middle of the report and in the end of the report. In the middle tables it should be printed as float, but in the last table it should be printed as "%" format. These are the previous requests from biology group before.

marrip · 2026-02-13T12:42:39Z

Hi Martin, Some other errors with further testings in outside.

There are different printing format for this column in the tables in the middle of the report and in the end of the report. In the middle tables it should be printed as float, but in the last table it should be printed as "%" format. These are the previous requests from biology group before.

I hope my latest patch fixes this. Again, I would like to maybe use the different inputs for insert_table_to_ppt() as test cases for a unit test. Maybe you could provide me with input cases that you want to be considered so I can make sure the function covers those. This way you would encounter less of these cases to fail 🙂

xiaoliz0 · 2026-04-28T11:12:09Z

Hi Martin, your updated codes are still not working with the data in our side. Maybe it is better we check this together in the meeting on Thursday?

xiaoliz0 · 2026-04-28T11:58:50Z

I think I fixed the codes with a new commit. Not sure if the push command is correctly. :)

marrip · 2026-04-28T13:17:54Z

I think I fixed the codes with a new commit. Not sure if the push command is correctly. :)

I don't see any new commit from you, did you push something? Or was it the last commit I had pushed that fixed the issue?

xiaoliz0 · 2026-04-29T06:36:43Z

I think I fixed the codes with a new commit. Not sure if the push command is correctly. :)

I don't see any new commit from you, did you push something? Or was it the last commit I had pushed that fixed the issue?

No, I think my commit creates another branch with PR99. I will try to commit here.

xiaoliz0

Fix some codes to make it work at OUS.

Co-authored-by: Xiaoli Zhang <81294502+xiaoliz0@users.noreply.github.com>

marrip · 2026-04-29T07:19:35Z

feel free to merge if this works for you ☺️

marrip added 3 commits January 29, 2026 13:35

chore: add pandas and sort alphabetically

bebe60c

feat: add function to normalize column indices

2d84df7

test: add unittests for column index normalization function

fd2e0ac

marrip requested a review from xiaoliz0 January 29, 2026 13:40

marrip self-assigned this Jan 29, 2026

marrip added 3 commits January 29, 2026 13:42

feat: use column index normalizing function in main script, add comme…

09e6aee

…nts and clean up

feat: make warning on empty file more specific

22edc4b

feat: simply variable setting via if statement

7f5509a

marrip added 2 commits February 3, 2026 14:26

feat: round floats in AF_tumor_DNA to 2 decimal places

282a54e

test: add unittests for rounding function

b88f652

marrip added 2 commits February 4, 2026 08:16

style: be consistent with using idx for index

2ec761f

chore: rename page_num to slide_idx to be consistent with naming

7f080ea

marrip added 2 commits February 5, 2026 13:56

fix: handle rouding if type is string

a81fa30

test: include test case for decimal rounding that contains strings

afdbf80

marrip added 4 commits February 5, 2026 13:59

feat: introduce functions to get table data per slide and add table n…

976c0ca

…ame to slide

style: add comments to code

51628f8

test: add tests for table data and table name functions

a686731

feat: refactor and simplify insert_table_to_ppt

bca5f7e

xiaoliz0 reviewed Feb 12, 2026

View reviewed changes

fix: use correct function name, thanks @xiaoliz0

ce3dced

fix: handle strings with % and floats in set_column_to_2_decimals

bb2dacc

marrip force-pushed the insert_table_to_ppt branch from 5d5ae85 to bb2dacc Compare February 13, 2026 12:40

xiaoliz0 requested a review from tonjegul April 28, 2026 11:11

xiaoliz0 requested changes Apr 29, 2026

View reviewed changes

Comment thread Script/PRONTO.py

Comment thread Script/PRONTO.py Outdated

Comment thread Script/PRONTO.py Outdated

fix: apply @xiaoliz0 's suggestions

26af7f0

Co-authored-by: Xiaoli Zhang <81294502+xiaoliz0@users.noreply.github.com>

xiaoliz0 merged commit 39705da into InPreD:develop_issue91 Apr 29, 2026

Conversation

marrip commented Jan 29, 2026

Uh oh!

xiaoliz0 commented Feb 3, 2026

Uh oh!

marrip commented Feb 3, 2026

Uh oh!

xiaoliz0 commented Feb 5, 2026

Uh oh!

marrip commented Feb 5, 2026

Uh oh!

marrip commented Feb 5, 2026

Uh oh!

xiaoliz0 Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

marrip Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

xiaoliz0 commented Feb 12, 2026

Uh oh!

marrip commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xiaoliz0 commented Apr 28, 2026

Uh oh!

xiaoliz0 commented Apr 28, 2026

Uh oh!

marrip commented Apr 28, 2026

Uh oh!

xiaoliz0 commented Apr 29, 2026

Uh oh!

xiaoliz0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marrip commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

marrip commented Feb 13, 2026 •

edited

Loading