This repository was archived by the owner on Dec 23, 2024. It is now read-only.
query param access token#24
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 177 193 +16
=====================================
+ Hits 177 193 +16
Continue to review full report at Codecov.
|
dselans
approved these changes
Mar 22, 2017
Contributor
dselans
left a comment
dselans
left a comment
There was a problem hiding this comment.
Leaving up to you to decide whether you update to switch or not.
| tokens: tokens, | ||
| } | ||
|
|
||
| if tokenType == "query" { |
Contributor
There was a problem hiding this comment.
I think a switch statement would be nice here - it's easier to read and see what's happening (and you can also set the default case to err if the tokenType is not supported (to prevent future, potential errors)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
option to read the access token from a query param