fix(terminal): make .md path links visibly clickable + harden fileRead errors#100
Merged
InbarR merged 2 commits intoMay 8, 2026
Merged
Conversation
…d errors
The xterm link provider for markdown file paths was registering matches without `decorations`, so matched .md paths in terminal output had no visual affordance - users had no way to tell they were clickable until the cursor happened to land exactly on one.
Changes:
- Add `decorations: { underline: true, pointerCursor: true }` to the md link descriptors so paths render with an underline and switch the cursor to a pointer on hover (mirrors the existing image link provider at line 609).
- Update tooltip from 'Ctrl+Click to preview' to 'Click to preview' to match the no-modifier activation behavior.
- Restructure the fileRead promise so a null return logs a warning (fileRead returned null) and a thrown error logs an error (fileRead threw), instead of silently dropping both. Helps triage 'looks clickable but doesn't open' reports.
- Widen the local links array type to match the proven shape used by the image link provider (decorations?, activate signature with MouseEvent/text).
Adds a focused Playwright spec for the changes in this PR:
- The .md link provider now emits each link with `decorations: { underline: true, pointerCursor: true }` so xterm renders an underline and switches the cursor on hover. Pre-PR the field was missing entirely.
- The tooltip text was reworded from 'Ctrl+Click to preview:' to 'Click to preview:' to match the no-modifier activation behavior.
Coverage scope is deliberately narrow - just the link provider's output shape via `provideLinks`. The fileRead null/throw branches that were also tightened in this PR are NOT covered here because the existing fileRead spy pattern (`Object.defineProperty` on `terminalAPI`) is currently broken across the whole e2e suite (task-107 fails with `Cannot redefine property: fileRead` on current main, suggesting a contextBridge tightening in a recent Electron upgrade). Once the spy infra is restored, follow-up tests for the warn/error branches should slot in here.
Verified locally: 1 passed (4.4s).
Contributor
Author
|
Took a stab at the test myself in commit Verified locally: 1 passed (4.4s). Coverage scope is deliberately narrow — just the link provider's output shape. The fileRead null/throw branches are not covered because the existing fileRead spy pattern ( |
InbarR
pushed a commit
that referenced
this pull request
May 8, 2026
Ink-based TUIs (Claude Code, Copilot CLI) wrap paths at their content width without setting xterm's `isWrapped` flag, so the existing soft-wrap walk in the .md link provider only saw the queried row. A path like `c:\Users\...\OneDrive -` + `Microsoft\...\note.md` fell back to the bare-filename branch on the continuation row, then opened cwd-relative against the wrong drive. Mirror the image-path provider's hard-newline stitch: - PATH_BODY seam check on both sides, capped at 4 rows so screens full of path-shaped tokens can't glue together. - Forward + backward walk so a click on either head or continuation row reconstructs the same logical string. - Restore one seam space when the post-wrap row had leading whitespace (preserves the spelling of paths with embedded spaces like `OneDrive - Microsoft\...`). - Update Seg shape and offsetToRowCol to track soft-vs-hard rows and per-row leading WS, matching the image-path provider's model. Rebased on top of PR #100 (ce4c1cf) which added decorations and fileRead error handling to the same provider; both fixes compose cleanly. No automated coverage in this commit - the e2e Playwright spec drafted for the repro hit the same launch-stage infra failure PR #100's author also flagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The xterm link provider for markdown file paths in TerminalPanel.tsx was registering
.mdmatches without anydecorations, so matched paths in terminal output had no visual affordance — users couldn't tell they were clickable until the cursor accidentally landed on one and the tooltip appeared.This PR makes
.mdpaths render with an underline and switch the cursor to a pointer on hover, mirroring the existing image link provider (line 609) and URL provider in the same file. Also tightens thefileReaderror handling so silent failures become loggable instead of vanishing.Tested locally: paths in
gh copilot/claudeoutput, in build error stacks, and indir/Get-ChildItemlistings all now show as clickable links.Changes
src/renderer/components/TerminalPanel.tsxDetailed changes (1 file, +12 / −5)
decorations: { underline: true, pointerCursor: true }on each registered link. Mirrors the proven pattern at line 609 (image link provider) in the same file.Ctrl+Click to preview: <path>→Click to preview: <path>(matches the no-modifier activation behavior — there is no Ctrl gating in the activate handler).fileRead— was: silent drop onnulland silent drop onthrow. Now:content === null→console.warn('[md-link] fileRead returned null', { fullPath })and return..catchlogsconsole.error('[md-link] fileRead threw', { fullPath, err }).This helps triage future "looks clickable but doesn't open" reports without changing the happy path.
linksarray type widened to match the proven shape used by the image link provider at line 531-536:activate: (e: MouseEvent, text: string) => voidanddecorations?: { underline?: boolean; pointerCursor?: boolean }. The implementationactivate() { ... }remains compatible (TS allows fewer params in implementations).Out of scope
console.warn/console.errorare a deliberate, narrow addition for triage — only fire on actual failures, not on every click. Happy to drop them or wire to a typed logger if you'd prefer.decorations). Did not changeMD_PATH_PATTERNor thefileReadIPC contract.__tmaxLinkActivates) the URL provider keeps for TASK-104/106 — happy to add a__tmaxMdLinkActivatesif useful for symmetry.Test plan
.mdpaths in terminal output now render with underline + pointer cursor; clicking opens the markdown preview overlay.decorationsfield or thefileReadcallback branches. Happy to add a Playwright spec asserting the activate path if you'd like a follow-up commit.Notes
main(18251d5).tsc --noEmiterror at line 729 that is structurally identical to the pre-existing one at line 613 (image link provider). The codebase doesn't gate ontsc --noEmit(main has 29 errors and ships), so this is consistent with house style. A separate cleanup of xterm link-provider TS strictness across all 3 providers (URL, image, md) would be a worthwhile follow-up.