feat(panel): middle-click pane title bar to close (TASK-107)#96
Merged
Merged
Conversation
Mirrors the existing tab middle-click-close UX from TabBar onto the per-pane title bar so the same gesture works uniformly on tiled panes and floating panels (both render the same .terminal-pane-title element). The new branch on the existing onMouseDown handler: - Bails when the click target is inside a button, input, or .status-dot-container so the rename input, X icon, and any nested buttons keep their existing semantics. - preventDefault suppresses Windows' middle-button auto-scroll cursor. - Calls closeTerminal(terminalId) for the doomed pane. Adds a Playwright spec covering: tiled close, floating close, status-dot/X no-op, and rename-input no-op (4/4 passing). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
|
Thanks @SolomonTomer - middle-click-to-close on the pane title bar is a great match for the existing tab UX. Spec coverage looks solid (4/4). Squash-merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the existing tab middle-click-close UX from TabBar onto the per-pane title bar so the same gesture works uniformly on tiled panes and floating panels (both render the same .terminal-pane-title element).
The new branch on the existing onMouseDown handler:
Adds a Playwright spec covering: tiled close, floating close, status-dot/X no-op, and rename-input no-op (4/4 passing).