Add Symfony 5 support#128
Closed
simonberton wants to merge 4 commits intoIncenteev:masterfrom
Closed
Conversation
|
@simonberton you can take a look at #129 to see why your tests are failing and fix them. |
Author
|
Hi @DonCallisto Should we remove the php 5.4, 5.5, 5.6 from the travis file ? |
|
Usually I would say no because this PR is for Symfony5 support so should not take into account php minimum version bumping but, as test will fail, I suggest to remove them in order to make the CI go green. |
|
Why did you closed this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#SymfonyHackday