This repository was archived by the owner on Aug 29, 2024. It is now read-only.
Validate IP addresses upon opening new sockets#3
Merged
includesec-kris merged 5 commits intoIncludeSecurity:mainfrom Jan 17, 2023
Merged
Validate IP addresses upon opening new sockets#3includesec-kris merged 5 commits intoIncludeSecurity:mainfrom
includesec-kris merged 5 commits intoIncludeSecurity:mainfrom
Conversation
urllib and urlparse are parts of the stdlib
Fixes IncludeSecurity#2. Instead of rewriting the hostname to be the IP address, instead we look at the resolved IP just before cURL opens the socket. This is fine since cURL's connection pools are per-handle so we don't have to worry about keep-alive and other handles' connections. This negates the need for DNS pinning, so enabling DNS pinning is now effectively a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2.
Instead of rewriting the hostname to be the IP address, instead we
look at the resolved IP just before cURL opens the socket. This is
fine since cURL's connection pools are per-handle so we don't have
to worry about keep-alive and other handles' connections.
This is also enabled by default because unlike the previous DNS pinning
implementation this won't break the TLS stack's
CNvalidation.This negates the need for DNS pinning, so enabling DNS pinning is
now effectively a no-op.