Skip to content

Response base class#12

Closed
bkuhl wants to merge 24 commits intoIndatus:masterfrom
bkuhl:response-base-class
Closed

Response base class#12
bkuhl wants to merge 24 commits intoIndatus:masterfrom
bkuhl:response-base-class

Conversation

@bkuhl
Copy link
Member

@bkuhl bkuhl commented Jul 23, 2014

  • Updated some phpdoc to use the fully qualified namespace
  • Response and RawResponse both extend a common class. While this doesn't add immediate value to Trucker itself, it allows for applications using Trucker to type hint to a Trucker BaseResponse.

Brian Webb and others added 22 commits March 19, 2014 12:28
added the ability to pass headers to the request raw methods
Conflicts:
	src/Trucker/Requests/RestRequest.php
updated recruiting banner.
…of-array

fixed error where object was being returned where it was expecting an array
…onse-base-class

Conflicts:
	src/Trucker/Requests/RestRequest.php
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.12%) when pulling 72fd9e3 on bkuhl:response-base-class into 3cff4a2 on Indatus:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.13%) when pulling 72fd9e3 on bkuhl:response-base-class into 3cff4a2 on Indatus:master.

@bkuhl
Copy link
Member Author

bkuhl commented Jul 23, 2014

BaseResponse has been removed from code coverage since it doesn't actually provide any functionality, but mainly offers method phpdoc and a common type hint for Responses.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.14%) when pulling 81ed422 on bkuhl:response-base-class into 3cff4a2 on Indatus:master.

@bkuhl bkuhl mentioned this pull request Jul 23, 2014
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.14%) when pulling ec2731c on bkuhl:response-base-class into 3cff4a2 on Indatus:master.

@bkuhl
Copy link
Member Author

bkuhl commented Jul 24, 2014

These changes were merged in as part of pull request #13

@bkuhl bkuhl closed this Jul 24, 2014
@bkuhl bkuhl deleted the response-base-class branch July 24, 2014 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants