[DEV-14958] Upgrade s3 storage version and add needed variables#553
Merged
emuzykin1 merged 2 commits intoIPA-7.5.11.rcfrom Mar 27, 2026
Merged
[DEV-14958] Upgrade s3 storage version and add needed variables#553emuzykin1 merged 2 commits intoIPA-7.5.11.rcfrom
emuzykin1 merged 2 commits intoIPA-7.5.11.rcfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| existing_kms_key = "${jsonencode(var.existing_kms_key)}" | ||
| bucket_versioning = "${jsonencode(var.bucket_versioning)}" | ||
| submission_expiry = "${jsonencode(var.submission_expiry)}" | ||
| uploads_expiry = "${jsonencode(var.uploads_expiry)}" |
There was a problem hiding this comment.
New variables missing from auto-generated smoketest configmap
Low Severity
The tf-smoketest-variables.tf file (which is auto-generated via generate-variables and marked "DO NOT EDIT") was manually edited to remove submission_expiry and uploads_expiry, but the new s3_cleanup_noncurrent_days and s3_retain_backup_days variables were not added. The file needs to be regenerated by running the generate-variables script so the Kubernetes ConfigMap used by smoke tests stays in sync with variables.tf.
emuzykin1
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Upgrades the S3 buckets Terraform module and changes lifecycle/retention inputs, which can alter object version and backup cleanup behavior if misconfigured.
Overview
Updates the
s3-storageTerraform module from4.5.0to4.6.0and switches S3 retention configuration from the oldersubmission_expiry/uploads_expiryinputs to new lifecycle controls.Adds
s3_cleanup_noncurrent_daysands3_retain_backup_daysvariables and wires them into the module viacleanup_noncurrent_daysandretain_backup_days, while removing the deprecated variables from smoke-test config and sampleuser_vars.auto.tfvars.Written by Cursor Bugbot for commit e4cb0a3. This will update automatically on new commits. Configure here.