Use implicit lifetime for query builder expr() arg#293
Open
dubrowgn wants to merge 1 commit intoIndra-db:mainfrom
Open
Use implicit lifetime for query builder expr() arg#293dubrowgn wants to merge 1 commit intoIndra-db:mainfrom
dubrowgn wants to merge 1 commit intoIndra-db:mainfrom
Conversation
`QueryBuilderImpl<'a>::expr` improperly ties the lifetime of the `expr` argument to the lifetime of the `QueryBuilderImpl` instance, despite not accessing the argument outside the scope of the function. This makes using the API with non-static query expressions difficult/impossible. Use an implicit lifetime for the `expr` argument, such that its lifetime is only tied to the duration of the function call. fixes: Indra-db#292
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QueryBuilderImpl<'a>::exprimproperly ties the lifetime of theexprargument to the lifetime of theQueryBuilderImplinstance, despite not accessing the argument outside the scope of the function. This makes using the API with non-static query expressions difficult/impossible.Use an implicit lifetime for the
exprargument, such that its lifetime is only tied to the duration of the function call.fixes: #292