Add card design_1 #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfJoker
requested changes
Oct 10, 2021
Flash_cards/HTML/flash_card.html
Outdated
| <br/> | ||
|
|
||
| <form action="путь к обработчику, который принимает данные"> | ||
| <p><input type="submit" value="Correct" style="height:100px; width:150px"> <input type="submit" value="Inorrect" style="height:100px; width:150px"></p> |
Flash_cards/HTML/flash_card.html
Outdated
|
|
||
| <style> | ||
| body { | ||
| background-image: url('pic.jpg'); |
Owner
There was a problem hiding this comment.
Что за картинка? pic.jpg - очень не говорящее название
Flash_cards/HTML/flash_card.html
Outdated
| @@ -0,0 +1,92 @@ | |||
| <!DOCTYPE html> | |||
Owner
There was a problem hiding this comment.
Нужно было бы убрать бинари, которые .DS_Store в gitignore. Другим иметь их копии не обязательно)
| @@ -0,0 +1,2 @@ | |||
| PyQt5 | |||
Owner
There was a problem hiding this comment.
не проще ли было отдельную ветку сделать, и запушить новый pr? А этот старый pr pyqt оставить в этом с одним коммитом, чтобы можно было всегда к нему вернутся. А так ты получается пушишь еще пока не нужную папку с pyqt.
Лучше так и сделать, сначала исправить текущий коммит, чтобы он ничего не делал с pyqt файлами. Потом с помощью git cherry-pick выбрать твой коммит на другой ветке и его туда там добавить. А на этой дропнуть этот коммит и залить раздельными pr-aми
InfJoker
approved these changes
Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.