En time pulse us#217
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables the machine.time_pulse_us() functionality for the PSoC6 port by adding the necessary configuration flag and comprehensive tests to verify the implementation.
- Added MICROPY_PY_MACHINE_PULSE configuration flag to enable time_pulse_us functionality
- Created test infrastructure to validate time_pulse_us accuracy using PWM signals
- Integrated time_pulse tests into the existing test suite with proper CI support
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| mpconfigport.h | Enables machine pulse functionality with configuration flag |
| time_pulse_us.py | Test implementation using PWM to validate time_pulse_us accuracy |
| time_pulse_us.exp | Expected test output for validation |
| run_psoc6_tests.sh | Test runner integration and infrastructure updates |
Comments suppressed due to low confidence (1)
jaenrig-ifx
left a comment
There was a problem hiding this comment.
Looks good. But for some reason not working in the HIL.
I also see that the main did not pass in the HIL:
https://github.com/Infineon/micropython/actions/runs/16243299752/job/45862593551
It seems the modtime is failing...
Not sure if that is related. But the pulse test is also failing in the HIL.
I have made required changes to fix breaking modtime tests and it works now. time_pulse_us test is supposed to fail as hardware connection is required. |
d8627e8 to
c24e320
Compare
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
f025200 to
9b9130d
Compare
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: NikhitaR-IFX <nikhita.rajasekhar@infineon.com>
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
8d25828 to
ca3d0c5
Compare
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
Summary
Enable machine.time_pulse_us() functionality and added tests using PWM.