Skip to content

Fix: Handle window size in native layer#124

Merged
AnnaSasDev merged 3 commits intoInfiniLore:corefrom
freakdaniel:embeds
Apr 5, 2026
Merged

Fix: Handle window size in native layer#124
AnnaSasDev merged 3 commits intoInfiniLore:corefrom
freakdaniel:embeds

Conversation

@freakdaniel
Copy link
Copy Markdown
Contributor

Description

This PR fixes the window size constraint properties so MaxHeight, MaxWidth, MinHeight, and MinWidth are retrieved from the native layer instead of being stored separately in managed C# state

Type of Change

  • Bug fix (non-breaking change fixing an issue)

Changes Made

  • Added native GetMaxSize and GetMinSize APIs and wired them through the export and C# interop layers
  • Updated InfiniFrameWindow to read min/max size constraints from native state, with startup parameter fallback before initialization
  • Removed managed-side caching of min/max window size constraints from the window builder and window extension methods
  • Implemented native min/max size getters for Windows, Linux, and macOS, and ensured Linux keeps its internal constraint values in sync when setters are called

Related Issues

Closes #79

Checklist

  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • All tests pass locally
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally
  • Any dependent changes have been merged and published

@freakdaniel freakdaniel changed the title Fix: Handle window size in managed native code Fix: Handle window size in native layer Apr 4, 2026
Comment thread src/InfiniFrame/InfiniFrameWindow.cs Outdated
@AnnaSasDev AnnaSasDev merged commit dfb81a3 into InfiniLore:core Apr 5, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BugReport | MaxHeight MinHeight MaxWidth MaxWidth should retreive their values from the native side and not store them locally in C#

2 participants