Fix: Implement icon file path resolution and validation#165
Merged
AnnaSasDev merged 4 commits intocorefrom Apr 6, 2026
Merged
Conversation
- Introduced `ResolveIconFilePath` utility to handle relative and absolute icon file paths. - Added tests for `IconFileUtilities` and `InfiniFrameNativeParametersValidator` to ensure correct resolution and validation behaviors. - Updated `InfiniWindowBuilderExtensions` and `InfiniWindowExtensions` to resolve and validate icon file paths during configuration. - Refactored `InfiniFrameWindowConfiguration` and startup logic to use resolved icon file paths. - Adjusted existing tests to reflect new path resolution logic.
… for improved null safety and clarity - Updated icon file resolution logic across the codebase to use `TryResolveIconFilePath` for clearer error handling. - Adjusted method signatures and modified conditional logic in `InfiniWindowBuilderExtensions`, `InfiniWindowExtensions`, and `InfiniFrameWindow` to support the new utility. - Enhanced `IconFileUtilities` with improved path resolution logic and out parameter usage. - Refactored tests to reflect changes, ensuring accurate validations for both found and missing paths.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…or consistency and improved readability
…solveIconFilePath` test for simplification and clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.