feat: route infiniop gemm through InfiniOps#1199
Open
voltjia wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR routes the existing
infiniopGemmC API through the InfiniOps C++ operator API.It is stacked on #1198 so the diff only contains the GEMM integration changes on top of
submodules/InfiniOps.Changes
infiniopGEMM descriptor/dispatch implementation with an adapter that callsinfini::ops::Operator<infini::ops::Gemm>::Call(...)infiniopagainstsubmodules/InfiniOps/build/src/libinfiniops.sosubmodules/InfiniOpsfrom316ad6b0to9444f9c3because316ad6b0fails to buildlibinfiniops.sowith generated optional-parameter call instantiationsVerification
Verified on
nvidia:Result:
Runtime smoke:
INFINI_ROOT=/tmp/infinicore-gemm-install \ LD_LIBRARY_PATH=/tmp/infinicore-gemm-install/lib:/tmp/infinicore-infiniops-gemm-clean/submodules/InfiniOps/build/src:/home/huangjiacheng/.venv/lib/python3.10/site-packages/torch/lib:$LD_LIBRARY_PATH \ /home/huangjiacheng/.venv/bin/python test/infiniop/gemm.py --nvidia --debugResult:
Also verified
ldd build/linux/x86_64/release/libinfiniop.soresolveslibinfiniops.sofromsubmodules/InfiniOps/build/src/libinfiniops.so.