Issue/127/feat. General Elementwise Framework with Refactored SwiGLU (CPU & CUDA) #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 8, 2025
Ziminli
force-pushed
the
issue/127_add_general_cuda_elementwise
branch
from
4f2a33e to
3232c29
Compare
Ziminli
force-pushed
the
issue/127_add_general_cuda_elementwise
branch
from
3232c29 to
1440e59
Compare
PanZezhong1725
requested changes
Apr 10, 2025
…on, refactor swiglu using the generic elementwise framework
…, add two broadcast testcases, correct elementwise cpu mix-precision implementation
…entwise calcualte and calculateImpl to return infiniStatus_t, add CHECK_CUDA to cuda function calls
… swiglu in swiglu_cuda.cuh
enable_if, remove std::move() in elementwise_cpu.h, add <array> inclusion
…adjust comment structure and template variable order
…space for storing meta, fix misc. issues
Ziminli
force-pushed
the
issue/127_add_general_cuda_elementwise
branch
from
a9ffc27 to
9cc0c41
Compare
…nge/correct kernel logic when all inputs have the same dtype
Collaborator
Author
|
Refactored the framework to use workspace. Passing all the cpu test cases (only show a portion of all the testcases): Passing all the cuda test cases (only show a portion of all the testcases): |
…s different dtypes
…n cuda elementwise files
PanZezhong1725
requested changes
Apr 15, 2025
…cros for indirecting variable names, change DeviceImpl to use Result for the return type of the create function, change CEIL_DIV
…M_DESCRIPTOR marcos
PanZezhong1725
approved these changes
Apr 15, 2025
YdrMaster
suggested changes
Apr 15, 2025
…for correct alignment and change the reference name of the Opaque struct to Opaque instead of struct Opaque
YdrMaster
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot for passing the swiglu CPU testcases:
Screenshot for passing the swiglu CUDA testcases:
