refactor: rename non-PascalCase function names per Google C++ style#63
Merged
refactor: rename non-PascalCase function names per Google C++ style#63
Conversation
Google C++ Style Guide requires PascalCase for non-accessor/mutator functions. `make` constructs an operator instance, so it does not qualify as an accessor.
Google C++ Style Guide requires PascalCase for non-accessor/mutator functions. `call` invokes the operator rather than accessing state.
Google C++ Style Guide requires PascalCase for non-accessor/mutator functions. `call` dispatches to an implementation rather than accessing state.
Google C++ Style Guide requires PascalCase for non-accessor/mutator functions. `ensure` performs a get-or-allocate action rather than a simple get/set of a named member.
Google C++ Style Guide requires PascalCase for namespace-scope functions. `workspacePool` was camelCase and is not an accessor of any class member.
Collaborator
Author
Ziminli
approved these changes
Apr 17, 2026
zhangyue207
pushed a commit
that referenced
this pull request
Apr 17, 2026
…name + drop registry.h (SFINAE autodetect)
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Google C++ Style Guide requires PascalCase for non-accessor/mutator functions. A few functions in the codebase did not follow this rule. This PR renames them:
Operator::make→Operator::MakeOperator::call→Operator::Calldetail::DispatchFuncUnwrap::call→CallWorkspacePool::ensure→EnsureworkspacePool→GetWorkspacePool(was alsocamelCase)Operator::active_implementation_indiceswas considered but kept — it reads as a getter (returns a derived property with no side effects), which the style guide allows to stay insnake_case.