Add Global Average Pool #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziminli
changed the title
Ziminli
force-pushed
the
add_global_avg_pool
branch
from
f797ad3 to
fcdc5f5
Compare
kilinchange
requested changes
Nov 1, 2024
| } | ||
|
|
||
| template<typename Tdata, typename TIdata, typename Ldata, typename LIdata> | ||
| void launch_global_avg_pool_folding(GlobalAvgPoolCudaDescriptor_t desc, void *y, void const *x, void *workspace, uint64_t workspace_size, void *stream, unsigned pack_size) { |
Collaborator
There was a problem hiding this comment.
这里为什么是根据 workspace_size 决定用哪个 kernel 呢？workspace_size 不是 kernel 自己返回的需求吗
Collaborator
Author
There was a problem hiding this comment.
是的，这里是根据是否有workspace进行优化，因为workspace根据不同的数据类型会有所变化，比如fp32和fp64这种情况下其实是不需要workspace的，这时候就不用调用有workspace的版本。如果像fp16需要workspace的话就会自动调用有workspace的版本。
PanZezhong1725
approved these changes
Nov 6, 2024
… remove some test cases, etc.
kilinchange
approved these changes
Nov 6, 2024
PanZezhong1725
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.