Add support for SpiNorFlash and FS#30
Merged
NeroBurner merged 5 commits intomainfrom May 15, 2022
Merged
Conversation
JF002
force-pushed
the
add-support-for-spinorflash-and-filesystem
branch
from
08617d4 to
5406909
Compare
JF002
changed the title
The external SPI flash is implemented as a 4MB on the local filesystem. This allows the FS (littleFS) and settings to work properly.
If by any chance the `char` type on a platform is implemented with more than one byte the `reinterpret_cast<char *>(buffer)` would change the meaning of the `size` parameter, which could lead to garbage data.
NeroBurner
force-pushed
the
add-support-for-spinorflash-and-filesystem
branch
from
5f2c6cf to
cbf32e8
Compare
Collaborator
|
Looking really good. Rebased, added a check that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SpiNorFlash is implemented as a 4MB file on the local filesystem. This allows the FS and settings to work properly.
I've also created this PR to experiment with resource loading from the SPI flash and hopefully find the best way to implement it in InfiniTime :)
After creating this branch, I noticed that another implementation of the FS layer have already been integrated. I feel like the one from this PR is closer to the real hardware, as it uses LittleFS and a file of the same size as the actual external memory of the PineTime, but I'm ok if you want to keep the current implementation ;-)