Build widgets in widgets folder#31
Merged
NeroBurner merged 2 commits intoInfiniTimeOrg:mainfrom May 15, 2022
Riksu9000:build-widgets
Merged
Build widgets in widgets folder#31NeroBurner merged 2 commits intoInfiniTimeOrg:mainfrom Riksu9000:build-widgets
NeroBurner merged 2 commits intoInfiniTimeOrg:mainfrom
Riksu9000:build-widgets
Conversation
Collaborator
|
although it doesn't make a real difference for the build, for completeness sake, yes please add the .h files to the globbing The build still works if the |
NeroBurner
reviewed
May 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InfiniTimeOrg/InfiniTime#1136 adds a new folder for source files. If it gets merged, this folder needs to be added to the build.
Should it match the .h files as well?