Allow manual trigger of CI workflow

[ghost]

#1229 introduced a manual trigger for the workflows.
With #1279 the functionality was removed again.

As this can be a useful feature for running workflows for other branches than develop, this PR reintroduces the workflow_dispatch trigger.

[ghost]

I've just kept the original two lines from the following commit. I don't understand why there are changes necessary if the same two lines were approved and merged only 7 weeks ago, with the exact same comment and similar reasoning:

commit 6303bd2
Author: Finlay Davidson finlay.davidson@coderclass.nl
Date: Sun Jul 10 16:46:24 2022 +0200

Fix Docker workflow not pushing on manual trigger

Also fix issue where workflow doesn't run on pull requests.
Also allow other workflows to be triggered manually.
Also don't trigger any workflows on pull requests to master, as
there shouldn't be any pull requests against master.

@Riksu9000 could you elaborate why the functionality needed to be removed in the first place?

[Riksu9000]

I never approved the change and I didn't know what the purpose of this line was because there was no reasoning. These workflows are supposed to be triggered by events, so I didn't think it was necessary to manually trigger it.

[ghost]

@Riksu9000 understandable. Do you think aee88e2 adds enough reasoning to prevent removal in the future, or is additional information necessary, for example a specific usecase, a walkthrough on how to use it or a section in the documentation?

BTW: #1229 seems to be the original PR.

[JF002]

I used the manual trigger functionality when I was testing the new Docker image the workflow that builds and pushes the images in Dockerhub. It allows to manually run a build without having to do actual changes in the code. It should not be used most of the time, though.

[NeroBurner]

@JF002 could you clarify your statement in respect to the current PR. Is it a "won't merge" or "we can merge it but we won't use it"?

[Riksu9000]

The way this works is that when the default branch has a workflow containing workflow_dispatch:, a button appears in the Actions tab that allows running the workflow manually, but using the workflow file from another branch.

As far as I know, it isn't enough for just the feature branch to contain this. I added this to the default branch in my fork to be able to test workflows.

[JF002]

I don't remember exactly why we removed this feature. As I said, it was useful when I was testing the docker image : I wanted to restart the same build of InfiniTime (no changes needed) with a new build of the Docker image.

It shouldn't be used that often, but I see no reason why we couldn't re-enable it again.