Fix double tap behaviour on PineTimeStyle settings screen#1669
Merged
Riksu9000 merged 1 commit intoInfiniTimeOrg:mainfrom Mar 4, 2023
Merged
Fix double tap behaviour on PineTimeStyle settings screen#1669Riksu9000 merged 1 commit intoInfiniTimeOrg:mainfrom
Riksu9000 merged 1 commit intoInfiniTimeOrg:mainfrom
Conversation
|
Build size and comparison to main:
|
FintasticMan
approved these changes
Mar 4, 2023
Member
FintasticMan
left a comment
FintasticMan
left a comment
There was a problem hiding this comment.
Nice to have this fixed. Just a couple of minor style changes I would suggest.
Riksu9000
approved these changes
Mar 4, 2023
Contributor
There was a problem hiding this comment.
We should find a more reliable approach to disabling touch events. Long tapping while the setting buttons are on the screen, the code gets executed each time. This could've been a problem if it created the objects multiple times.
In the mean time, I'll merge this to fix the bug. Thanks.
Ceimour
pushed a commit
to Ceimour/InfiniTime
that referenced
this pull request
Mar 16, 2023
Fixes InfiniTimeOrg#1467 "Double tapping PineTimeStyle steps style button sends watch to sleep" Double tap is disabled on the color settings screen by checking if the Rnd button is visible, but this didn't work for the options screen as the Rnd button isn't visible. I've changed it to check if the Close button is visible instead, which is used on both settings screens, and resolves the bug. I also changed the button used to disable the long press behaviour which was an as-yet-undiscovered bug which would have allowed the long press action to be used when the options screen was visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1467 "Double tapping PineTimeStyle steps style button sends watch to sleep"
Double tap is disabled on the color settings screen by checking if the Rnd button is visible, but this didn't work for the options screen as the Rnd button isn't visible. I've changed it to check if the Close button is visible instead, which is used on both settings screens, and resolves the bug. I also changed the button used to disable the long press behaviour which was an as-yet-undiscovered bug which would have allowed the long press action to be used when the options screen was visible.