Simple Weather Service : Fix timestamp#1945
Merged
Merged
Conversation
In the documentation, specify that the timestamp is expressed in seconds from epoch (instead of nanoseconds). SimpleWeatherService now uses "localtime" (GetCurrentDateTime()) instead of UTC time.
|
Build size and comparison to main:
|
NeroBurner
approved these changes
Jan 2, 2024
FintasticMan
requested changes
Jan 2, 2024
Member
FintasticMan
left a comment
FintasticMan
left a comment
There was a problem hiding this comment.
I think we should mention in the doc that we expect the timestamp to be in local time.
Mention that the timestamp should be expressed in localtime time.
Collaborator
Author
Yes, right! Done! |
FintasticMan
approved these changes
Jan 2, 2024
NeroBurner
approved these changes
Jan 3, 2024
Contributor
NeroBurner
left a comment
NeroBurner
left a comment
There was a problem hiding this comment.
small wording change, afterwards I'm good again :)
Wording improvements in doc. Co-authored-by: Reinhold Gschweicher <pyro4hell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the documentation, specify that the timestamp is expressed in seconds from epoch (instead of nanoseconds). SimpleWeatherService now uses "localtime" (GetCurrentDateTime()) instead of UTC time.