Add an optional help text to CheckboxList to explain that resources are missing#2214
Open
ljahn wants to merge 2 commits intoInfiniTimeOrg:mainfrom
Open
Add an optional help text to CheckboxList to explain that resources are missing#2214ljahn wants to merge 2 commits intoInfiniTimeOrg:mainfrom
ljahn wants to merge 2 commits intoInfiniTimeOrg:mainfrom
Conversation
|
Build size and comparison to main:
|
mark9064
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2196
This adds an optional help text to the
CheckboxList. It is done as an additional argument in the constructor that isnullptrby default. This way, no changes to other code are needed. If a help text is supplied it scrolls along the very bottom of the screen.If any watch face signals it is not available, the message "Resources missing! Install resource pack to use greyed out watch faces." Is displayed on the corresponding selection screen.