Added stopwatch#231
Conversation
…d to replace with paddle app in displayApp.cpp and ApplicationList.cpp later.
|
Looks awesome! Thanks for this PR and sorry for the delay. I'll try to review it soon ;) |
| {Symbols::paintbrush, Apps::Paint}, | ||
| {Symbols::info, Apps::Notifications}, | ||
| {Symbols::paddle, Apps::Paddle}, | ||
| //TODO: Need to find the right place based on comments from JF |
There was a problem hiding this comment.
You can take the slot of the 'Meter' app. This app is a simple demo app I added as a placeholder when there was no other apps available in InfiniTime. Now, we can remove it :)
That way, we'll keep the game Paddle in place ;)
|
|
||
| namespace Pinetime::Applications::Screens { | ||
|
|
||
| enum class States { INIT, RUNNING, HALTED }; |
There was a problem hiding this comment.
Other enum classes do not name their values with CAPITAL letters. Could you rename these as 'Init', 'Running' and 'Halted' for more consistency?
Same for Events.
| } | ||
|
|
||
| private: | ||
| std::array<TimeSeparated_t, N> _arr; |
There was a problem hiding this comment.
Also for more consistency with the rest of the code : could you rename _arr as array for example? And maybe also currentSz to currentSize?
|
I've just tested and reviewed your PR : it works as expected, and the code is pretty straightforward. Thanks! |
|
Thanks for your comments. I made all the changes and also tested it once. Just a note, I did a git pull of your develop branch and now I also see the lvgl submodules have been updated (src/libs/lvgl) in my PR. I didn't expect them but could you verify if it is ok or if I messed something up when I pulled your changes? |
|
Thanks for the fixes! |
|
Hi JF, I think now it is ready to be merged. :) |
| case Apps::Twos: currentScreen.reset(new Screens::Twos(this)); break; | ||
| case Apps::Paint: currentScreen.reset(new Screens::InfiniPaint(this, lvgl)); break; | ||
| case Apps::Paddle: currentScreen.reset(new Screens::Paddle(this, lvgl)); break; | ||
| //TODO: Change it back |
There was a problem hiding this comment.
I just realized I forgot to revert this. I Will do it now.
I think you have to do a |
|
I did do the git submodule update, but somehow nothing changed. Anyway, I think everything is in order now and I also tested the paddle app so that I didn't introduce any regression. I think now the PR is definitely ready to be merged :) |
2 participants
Addresses issue: #144
Added a stopwatch with all the necessary functions such as play, pause, lap, stop.
For now, I hijacked the position of the paddle app. Let me know where the stopwatch belong in the app list :)