Skip to content

Analog face constexpr fix #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mark9064 merged 1 commit into from
Jun 28, 2025
Merged

Analog face constexpr fix #2327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/displayapp/screens/WatchFaceAnalog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include "displayapp/screens/WatchFaceAnalog.h"
#include <cmath>
#include <limits>
#include <lvgl/lvgl.h>
#include "displayapp/screens/BatteryIcon.h"
#include "displayapp/screens/BleIcon.h"
Expand All @@ -15,8 +16,10 @@ namespace {
constexpr int16_t MinuteLength = 90;
constexpr int16_t SecondLength = 110;

// LVGL sin isn't constexpr (though it could be if it were C++) so fix size here
// All the types are hardcoded anyway and would need changing if the size changed
// sin(90) = 1 so the value of _lv_trigo_sin(90) is the scaling factor
const auto LV_TRIG_SCALE = _lv_trigo_sin(90);
constexpr int16_t LV_TRIG_SCALE = std::numeric_limits<int16_t>::max(); // = _lv_trigo_sin(90)

int16_t Cosine(int16_t angle) {
return _lv_trigo_sin(angle + 90);
Expand Down