Skip to content

New Steps app#298

Merged
JF002 merged 3 commits intoInfiniTimeOrg:developfrom
joaquimorg:StepsApp
May 15, 2021
Merged

New Steps app#298
JF002 merged 3 commits intoInfiniTimeOrg:developfrom
joaquimorg:StepsApp

Conversation

@joaquimorg
Copy link
Copy Markdown
Contributor

  • New Steps app
  • Settings to set the steps goal
  • More detail in Motion app
  • New 42px Font

IMG_20210419_152300

IMG_20210419_153435

IMG_20210419_152316

Settings to set the steps goal
More detail in Motion app
New 42px Font
Copy link
Copy Markdown
Contributor

@petterhs petterhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Everything works and looks good.
Minor improvements:

  • Make the +/- buttons in step settings a bit bigger
  • Make 10000 steps default goal instead of 1000

Future possibilities:

  • Have a notification when goal is hit
  • Possible to turn step counting off in settings
  • (Move Motion app somewhere in the settings as it is more of a testing/debug application now at least)

@pfeerick
Copy link
Copy Markdown
Contributor

Looks great! I agree on all the points @petterhs made. Particularly the 10,000 steps part, as I was part of a active living promotion/campaign 10 or so years ago... funnily enough, called 10,000 steps 😆

@joaquimorg
Copy link
Copy Markdown
Contributor Author

joaquimorg commented Apr 20, 2021

Very nice! Everything works and looks good.
Minor improvements:

  • Make the +/- buttons in step settings a bit bigger
  • Make 10000 steps default goal instead of 1000

Yes, I will make the changes.

@pfeerick
Copy link
Copy Markdown
Contributor

pfeerick commented Apr 21, 2021

I've just tried this, and it looks and works great. Rather strangely, it seems like it still defaulted to 1000, but I'm definitely on 5fc07a8, so it should be using the new default of 10000. I DFU updated from the 1.0.0 RC4, so it's not like I'd already set and saved a value. Just in case someone else gets the same behaviour, or it was just something in the Matrix ;) Edit: answered below

@petterhs
Copy link
Copy Markdown
Contributor

I've just tried this, and it looks and works great. Rather strangely, it seems like it still defaulted to 1000, but I'm definitely on 5fc07a8, so it should be using the new default of 10000. I DFU updated from the 1.0.0 RC4, so it's not like I'd already set and saved a value. Just in case someone else gets the same behaviour, or it was just something in the Matrix ;)

The stepsGoal value in settings is already present in the RC's so then value 1000 was already loaded to you SPI flash

@pfeerick
Copy link
Copy Markdown
Contributor

Ah, fair enough... thank you @petterhs! :) In that case, it works perfectly.

As far as the motion app... I don't see why it can't stay where it is... it's as much a toy as the paint app is... I see it more as a demo of the sensors that can be read, which can get the boot when space becomes an issue or there are enough apps to warrant the slot wanted.

@ObiKeahloa
Copy link
Copy Markdown
Contributor

Really excited about this! The default app should be moved somewhere else , maybe a hidden settings menu? Similar to what @petterhs was saying.

@JF002
Copy link
Copy Markdown
Collaborator

JF002 commented May 2, 2021

Nice PR, as always, @joaquimorg. I'll try to review it soon!
I checked the memory usage : this PR adds ~12KB in flash memory (because of the new font, I guess). That's ok, there's still some room, but we are getting closer and closer to the limit of our internal flash space...

About the font : I think it would be useful to update the doc in src/displayapp/fonts to explain how to regenerate the new fonts (size, character ranges,...).

@JF002 JF002 added this to the Version 1.1 milestone May 2, 2021
@JF002
Copy link
Copy Markdown
Collaborator

JF002 commented May 10, 2021

While testing the settings app for the Steps, I noticed that it's not easy to tap on the buttons. It looks like the "hitbox" is really small. Is there something we can do about this?

As far as the motion app... I don't see why it can't stay where it is... it's as much a toy as the paint app is... I see it more as a demo of the sensors that can be read, which can get the boot when space becomes an issue or there are enough apps to warrant the slot wanted.

I agree with this. The motion app is not that useful. I implemented it to test the motion sensor, and it served as a placeholder while we didn't have a decent Steps app. Now, we can keep it (as @joaquimorg helped maintaining it :) ) or remove it (an free a few bytes of memory by disabling the Graph widget from LVGL). What's your opinion?

@joaquimorg
Copy link
Copy Markdown
Contributor Author

What I was able to validate is that the problem is not the size of the button but the interval between each touch, if it is too fast it does not detect the touch on the button, but if we take a short break between each touch it works well, I will try to understand whatever might be behind it.

As for the Motion application, I think that for now it can stay, I use it to validate if the accelerometer is working, later on when there is a need for space we can remove it.

@JF002
Copy link
Copy Markdown
Collaborator

JF002 commented May 11, 2021

@joaquimorg you might be right about the interval between 2 taps. If it's the case, that would be an issue that could be handled in another issue/PR.
Let me know if you find something interesting about this!

And I agree with you about the motion app ;)

@JF002 JF002 merged commit 09977c2 into InfiniTimeOrg:develop May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants