Fix stopwatch crash after stop pressed#324
Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom May 9, 2021
MFAshby:fix_stop_crash_315
Merged
Fix stopwatch crash after stop pressed#324JF002 merged 1 commit intoInfiniTimeOrg:developfrom MFAshby:fix_stop_crash_315
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
MFAshby:fix_stop_crash_315
Conversation
Contributor
Author
|
pinetime-mcuboot-app-dfu-1.0.0.zip |
Collaborator
|
Yes, PRs are merged into |
The lv_obj_del is called on btnStopLap when transitioning to the initial state, however the variable isn't then set to null. A subsequent call to Refresh would attempt to delete the already freed object. This could be triggered by stopping the stop watch, then pressing the physical button on the watch. Fixes #315
Contributor
Author
|
Thanks! I've rebased it. |
Collaborator
|
@MFAshby Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315
I've opened this PR to master as that's what I worked from, but please let me know if I should re-target to
developbranch.