Skip to content

add basic metronome app#409

Merged
JF002 merged 7 commits intoInfiniTimeOrg:developfrom
hall:metronome
Jun 12, 2021
Merged

add basic metronome app#409
JF002 merged 7 commits intoInfiniTimeOrg:developfrom
hall:metronome

Conversation

@hall
Copy link
Copy Markdown
Contributor

@hall hall commented Jun 2, 2021

A simple app that triggers a vibration based on the user-selected beats per minute (closes #361).

screenshot

What's done:

  • drag/click arc to select bpm
  • tap to select bpm
  • set bpb (beats per bar, for creating an accent beat)

@hall hall changed the title add basic metronome app WIP: add basic metronome app Jun 2, 2021
@hall hall marked this pull request as draft June 2, 2021 19:07
@hall hall changed the title WIP: add basic metronome app add basic metronome app Jun 2, 2021
@hall hall marked this pull request as ready for review June 4, 2021 09:44
@hall
Copy link
Copy Markdown
Contributor Author

hall commented Jun 4, 2021

Despite setting

lv_arc_set_adjustable(bpmArc, true);

the arc doesn't show the knob (tried adding styles as seen in the diff as well) and cannot be clicked or dragged to a new value.

@hall
Copy link
Copy Markdown
Contributor Author

hall commented Jun 4, 2021

Fixed arc selection by enabling the polling touch mode.

app->SetTouchMode(DisplayApp::TouchModes::Polling);

Copy link
Copy Markdown

@GatewayBit GatewayBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to re-enable sleep state in destructor.

Comment thread src/displayapp/screens/Metronome.cpp
@JF002
Copy link
Copy Markdown
Collaborator

JF002 commented Jun 12, 2021

@hall Nice app! As a (very amateur) drummer, I appreciate it!

Next step: find a nice icon for the app.
I'll merge this PR, but feel free to update it with an icon if you find one ;)

@JF002 JF002 merged commit c575754 into InfiniTimeOrg:develop Jun 12, 2021
@JF002 JF002 added this to the Version 1.2 milestone Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metronome app?

3 participants