PineTimeStyle step gauge bugfix#468
Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom Jul 11, 2021
Merged
Conversation
kieranc
changed the title
kieranc
changed the title
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The step gauge seems to have issues if the range is over 100, so this change sets the gauge range to 100 and calculates the step count as a percentage of the step goal to show progress.
Edit for a bit more context. Previously I was scaling the step gauge by adjusting the range, so a step goal of 13000 would make the range of the gauge 0-130, which resulted in only 9 divisions appearing. I'm not sure why this happened, but this fix changes the approach by setting the gauge range to 0-100 always, then calculating the needle position/progress as a percentage of the step goal.